In message: Fix a build failure on zeus v5.2/standard/xlnx-soc
on 08/05/2020 Zhang Xiao wrote:
> Hi Bruce,
>
> On zeus, branch "v5.2/standard/xlnx-soc" has a build error:
> ...
> drivers/gpio/gpio-xilinx.c:153:7: error: 'index' undeclared (first use in
> this function)
> 153 | if (index != xgpio_index(chip, i)) {
> | ^~~~~
> drivers/gpio/gpio-xilinx.c:153:7: note: each undeclared identifier is
> reported only once for each function it appears in
> CC drivers/i2c/busses/i2c-xiic.o
> drivers/gpio/gpio-xilinx.c:153:17: error: implicit declaration of function
> 'xgpio_index'; did you mean 'xgpio_set'?
> [-Werror=implicit-function-declaration]
> 153 | if (index != xgpio_index(chip, i)) {
> | ^~~~~~~~~~~
> | xgpio_set
> ...
>
> It was caused by
>
> http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/diff/drivers/gpio/gpio-xilinx.c?h=v5.2/standard/xlnx-soc&id=0986b237a48540c2be3222737
>
> to fix the conflict caused by:
>
> http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto/commit/arch/x86/kernel/cpu/mce/dev-mcelog.c?h=v5.2/standard/xlnx-soc&id=0861e61e86a5d
>
> Not like other BSP/branches, xilinx uses an old gpio driver. It doesn't use
> "index" and has no such issue so I think we can just revert it.
agreed.
I've merged the change.
Bruce
>
>
>
> Thanks
> Xiao
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#8648):
https://lists.yoctoproject.org/g/linux-yocto/message/8648
Mute This Topic: https://lists.yoctoproject.org/mt/74067890/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
