On 22. 05. 20 8:19, Michal Simek wrote: > On 22. 05. 20 4:34, [email protected] wrote: >> From: Quanyang Wang <[email protected]> >> >> According to commit 5eb5afb07853d6e9 ("usb: dwc3: use proper initializers >> for property entries"), property entries should be initialized by proper >> initializer macros. If not, the elements "is_inline" and "length" in >> structure property_entry will be zeros, and the function >> "property_entry_copy_data" will return -ENODATA failure. This will result >> that dwc3_host_init fails. >> >> Signed-off-by: Quanyang Wang <[email protected]> >> --- >> drivers/usb/dwc3/host.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c >> index 74cb49347b46..101b791d18f2 100644 >> --- a/drivers/usb/dwc3/host.c >> +++ b/drivers/usb/dwc3/host.c >> @@ -105,7 +105,7 @@ int dwc3_host_init(struct dwc3 *dwc) >> >> if (device_property_read_bool(&dwc3_pdev->dev, >> "snps,xhci-stream-quirk")) >> - props[prop_idx++].name = "xhci-stream-quirk"; >> + props[prop_idx++] = PROPERTY_ENTRY_BOOL("xhci-stream-quirk"); >> >> /** >> * WORKAROUND: dwc3 revisions <=3.00a have a limitation >> > > Piyush: Can you please take a look?
Got reaction. The patch is fine. Acked-by: Michal Simek <[email protected]> Bruce: Please take it to your branches. Thanks, Michal
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#8769): https://lists.yoctoproject.org/g/linux-yocto/message/8769 Mute This Topic: https://lists.yoctoproject.org/mt/74391261/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
