merged. Bruce
In message: [linux-yocto][linux-yocto v5.4/standard/nxp-s32g2xx][PATCH] s32gen1: pcie: wrap functions with related macro definition on 30/11/2020 Xulin Sun wrote: > In order to fix below compile warnings: > > drivers/pci/controller/dwc/pci-s32gen1.c:838:12: warning: > 's32gen1_pcie_config_irq' defined but not used [-Wunused-function] > 838 | static int s32gen1_pcie_config_irq(int *irq_id, char *irq_name, > | ^~~~~~~~~~~~~~~~~~~~~~~ > drivers/pci/controller/dwc/pci-s32gen1.c:782:20: warning: > 's32gen1_pcie_msi_handler' defined but not used [-Wunused-function] > 782 | static irqreturn_t s32gen1_pcie_msi_handler(int irq, void *arg) > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > Signed-off-by: Xulin Sun <[email protected]> > --- > drivers/pci/controller/dwc/pci-s32gen1.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pci-s32gen1.c > b/drivers/pci/controller/dwc/pci-s32gen1.c > index 748adb4015e8..61fad9b3801e 100644 > --- a/drivers/pci/controller/dwc/pci-s32gen1.c > +++ b/drivers/pci/controller/dwc/pci-s32gen1.c > @@ -774,7 +774,7 @@ static void s32gen1_pcie_stop_link(struct dw_pcie *pcie) > s32gen1_pcie_disable_ltssm(s32_pp); > } > > -#ifdef CONFIG_PCI_MSI > +#ifdef CONFIG_PCI_S32GEN1_EP_MSI > /* msi IRQ handler > * irq - interrupt number > * arg - pointer to the "struct pcie_port" object > @@ -834,6 +834,7 @@ static struct dw_pcie_host_ops s32gen1_pcie_host_ops = { > #endif > }; > > +#if defined(CONFIG_PCI_S32GEN1_EP_MSI) || defined(CONFIG_PCI_DW_DMA) > #define MAX_IRQ_NAME_SIZE 32 > static int s32gen1_pcie_config_irq(int *irq_id, char *irq_name, > struct platform_device *pdev, > @@ -861,6 +862,7 @@ static int s32gen1_pcie_config_irq(int *irq_id, char > *irq_name, > > return 0; > } > +#endif > > static int __init s32gen1_add_pcie_port(struct pcie_port *pp, > struct platform_device *pdev) > -- > 2.17.1 >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9210): https://lists.yoctoproject.org/g/linux-yocto/message/9210 Mute This Topic: https://lists.yoctoproject.org/mt/78604226/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
