This patch is to fix the following warnings:
1. warning: 's32gen1_pcie_config_irq' defined but not used
2. warning: 's32gen1_pcie_msi_handler' defined but not used
The functions are introduced in commit aefb6f1e55ad("s32gen1: Add
initial PCIe support (RC/EP)"), and the issues caused by commit
3beacb5469c7("s32gen1:pcie: Refactor pcie code"). The reason is that
the configs used, when they are defined and invoked, are different,
so fix them.
Signed-off-by: Zhantao Tang <[email protected]>
---
drivers/pci/controller/dwc/pci-s32gen1.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pci-s32gen1.c
b/drivers/pci/controller/dwc/pci-s32gen1.c
index 9bef5cb09386..bdb39ff3bb21 100644
--- a/drivers/pci/controller/dwc/pci-s32gen1.c
+++ b/drivers/pci/controller/dwc/pci-s32gen1.c
@@ -712,7 +712,7 @@ static void s32gen1_pcie_stop_link(struct dw_pcie *pcie)
s32gen1_pcie_disable_ltssm(s32_pp);
}
-#ifdef CONFIG_PCI_MSI
+#ifdef CONFIG_PCI_S32GEN1_EP_MSI
/* msi IRQ handler
* irq - interrupt number
* arg - pointer to the "struct pcie_port" object
@@ -894,6 +894,7 @@ static irqreturn_t s32gen1_pcie_hot_plug_thread(int irq,
void *arg)
return IRQ_HANDLED;
}
+#if defined(CONFIG_PCI_S32GEN1_EP_MSI) || defined(CONFIG_PCI_DW_DMA)
#define MAX_IRQ_NAME_SIZE 32
static int s32gen1_pcie_config_irq(int *irq_id, char *irq_name,
struct platform_device *pdev,
@@ -924,6 +925,7 @@ static int s32gen1_pcie_config_irq(int *irq_id, char
*irq_name,
return 0;
}
+#endif
static int s32gen1_pcie_config_hp_irq(struct s32gen1_pcie *s32_pp,
struct platform_device *pdev)
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#10847):
https://lists.yoctoproject.org/g/linux-yocto/message/10847
Mute This Topic: https://lists.yoctoproject.org/mt/88533290/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
