No objections here, a couple of suggested cleanups and a question. The question: did it boot ? We should capture the boot log in our initial commit, that way it can be a reference.
In message: [linux-yocto] [PATCH] qemuarm64: Add tiny ktype to qemuarm64 bsp on 22/01/2022 Alejandro Hernandez Samaniego wrote: > Allow linux-yocto-tiny to be built on qemuarm64. > > Signed-off-by: Alejandro Enedino Hernandez Samaniego > <[email protected]> > --- > bsp/qemuarm64/qemuarm64-tiny.cfg | 6 ++++++ > bsp/qemuarm64/qemuarm64-tiny.scc | 14 ++++++++++++++ > 2 files changed, 20 insertions(+) > create mode 100644 bsp/qemuarm64/qemuarm64-tiny.cfg > create mode 100644 bsp/qemuarm64/qemuarm64-tiny.scc > > diff --git a/bsp/qemuarm64/qemuarm64-tiny.cfg > b/bsp/qemuarm64/qemuarm64-tiny.cfg > new file mode 100644 > index 00000000..81ad88ee > --- /dev/null > +++ b/bsp/qemuarm64/qemuarm64-tiny.cfg > @@ -0,0 +1,6 @@ > +CONFIG_TTY=y > +CONFIG_VIRTIO_MENU=y > +CONFIG_VIRTIO_PCI=y > +CONFIG_VIRTIO=y > +CONFIG_VIRTIO_CONSOLE=y > +CONFIG_HVC_DRIVER=y It might be worth adding a comment that these are the minimum "extra" configurations for qemuarm64-tiny for boot. And by extra, I mean that aren't enabled after the allnoconfig -> main tiny ktype -> the standard qemuarm64 BSP fragments. Actually, thinking on that more .. we could easily argue that these could just go into the fragments included by the qemuarm64.scc. They won't hurt those fragments, since they are larger configs anyway, and would make sure that the main BSP fragments work in all the ktypes. > \ No newline at end of file > diff --git a/bsp/qemuarm64/qemuarm64-tiny.scc > b/bsp/qemuarm64/qemuarm64-tiny.scc > new file mode 100644 > index 00000000..4f698778 > --- /dev/null > +++ b/bsp/qemuarm64/qemuarm64-tiny.scc > @@ -0,0 +1,14 @@ > +# SPDX-License-Identifier: MIT > +define KMACHINE qemuarm64 > +define KTYPE tiny > +define KARCH arm64 > + > +include ktypes/tiny/tiny.scc > +branch qemuarm64 > + > +include cfg/virtio.scc > +include qemuarm64.scc > + > +# enable the ability to run 32 bit apps > +include arch/arm/32bit-compat.scc This looks fine to me. Good reuse of the existing fragments, so thanks for that! Bruce > +include qemuarm64-tiny.cfg > \ No newline at end of file > -- > 2.25.1 > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#10863): https://lists.yoctoproject.org/g/linux-yocto/message/10863 Mute This Topic: https://lists.yoctoproject.org/mt/88615699/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
