I have the same fix locally, as I was staging the -stable followed by
an update to -rt ... you caught it right in the middle!

5.18 -rt doesn't have the issue (yet) and 5.19-rt just keeps the
deferred printing around, so this is the right thing to do on 5.15.

I should have everything pushed to the servers shortly.

Bruce


On Mon, Aug 1, 2022 at 6:19 AM He Zhe <[email protected]> wrote:
>
> 46d5575df8a1 ("sched/deadline: Fix BUG_ON condition for deboosted tasks")
> uses printk_deferred_once while
> 25f13bd1d07b ("printk: remove deferred printing") remove the function in
> RT upstream. Let's use printk_once instead to fix the build failure.
>
> kernel-source/kernel/sched/deadline.c: In function 'enqueue_task_dl':
> kernel-source/kernel/sched/deadline.c:1565:25: error:
> implicit declaration of function 'printk_deferred_once' 
> [-Werror=implicit-function-declaration]
> 1565 |                         printk_deferred_once("sched: DL de-boosted 
> task PID %d: REPLENISH flag missing\n",
>      |                         ^~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: He Zhe <[email protected]>
> ---
>  kernel/sched/deadline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index c9dc1bc06431..4c6579cb1b7f 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1562,7 +1562,7 @@ static void enqueue_task_dl(struct rq *rq, struct 
> task_struct *p, int flags)
>                  */
>                 p->dl.dl_throttled = 0;
>                 if (!(flags & ENQUEUE_REPLENISH))
> -                       printk_deferred_once("sched: DL de-boosted task PID 
> %d: REPLENISH flag missing\n",
> +                       printk_once("sched: DL de-boosted task PID %d: 
> REPLENISH flag missing\n",
>                                              task_pid_nr(p));
>
>                 return;
> --
> 2.17.1
>


--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#11526): 
https://lists.yoctoproject.org/g/linux-yocto/message/11526
Mute This Topic: https://lists.yoctoproject.org/mt/92743928/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to