In message: Re: [linux-yocto][linux-yocto v5.15/standard/preempt-rt/nxp-sdk-5.15/nxp-soc & v5.15/standard/nxp-sdk-5.15/nxp-soc][PATCH1/1] video: fbdev: mxsfb: Use display_timings_release instead of kfree to release display_timings on 02/08/2022 Wang, Xiaolei wrote:
> Hi bruce > > please help me merge this patch Your email to drop the patch managed to mess up my scripts and I missed it completely. This is now merged. Bruce > > thanks > xiaolei > ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ > From: [email protected] <[email protected]> > on behalf of Xiaolei Wang <[email protected]> > Sent: Monday, July 25, 2022 1:57 PM > To: [email protected] <[email protected]> > Cc: [email protected] <[email protected]> > Subject: [linux-yocto][linux-yocto v5.15/standard/preempt-rt/nxp-sdk-5.15/ > nxp-soc & v5.15/standard/nxp-sdk-5.15/nxp-soc][PATCH1/1] video: fbdev: mxsfb: > Use display_timings_release instead of kfree to release display_timings > > Use display_timings_release to release display_timings to > avoid the following memleak. > > unreferenced object 0xc69fd000 (size 64): > comm "swapper/0", pid 1, jiffies 4294940574 (age 7409.380s) > hex dump (first 32 bytes): > 00 84 9f c6 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [<a67c882b>] of_get_display_timings+0x10c/0x1f8 > [<6c0b1585>] mxsfb_init_fbinfo_dt+0x198/0x2c0 > [<7d55b33e>] mxsfb_probe+0x334/0x984 > [<5c544ca0>] platform_probe+0x60/0xb0 > [<c778952e>] really_probe+0x178/0x308 > [<596dafe7>] __driver_probe_device+0xcc/0xe0 > [<1141d4b6>] driver_probe_device+0x48/0xc8 > [<50670d65>] __driver_attach+0xc8/0xdc > [<34daaf56>] bus_for_each_dev+0x74/0xac > [<ff6757f8>] bus_add_driver+0xb8/0x1c8 > [<6b24f4d4>] driver_register+0xb4/0xf8 > [<77418d84>] do_one_initcall+0x110/0x2d8 > [<62be8b21>] kernel_init_freeable+0x2e4/0x338 > [<776959eb>] kernel_init+0x18/0x138 > [<4b7fac1f>] ret_from_fork+0x14/0x38 > [<00000000>] 0x0 > > Signed-off-by: Xiaolei Wang <[email protected]> > --- > drivers/video/fbdev/mxsfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/mxsfb.c b/drivers/video/fbdev/mxsfb.c > index 86227802224d..df713d293096 100644 > --- a/drivers/video/fbdev/mxsfb.c > +++ b/drivers/video/fbdev/mxsfb.c > @@ -1407,7 +1407,7 @@ static int mxsfb_init_fbinfo_dt(struct mxsfb_info *host) > of_node_put(timings_np); > put_display_node: > if (timings) > - kfree(timings); > + display_timings_release(timings); > of_node_put(display_np); > return ret; > } > -- > 2.25.1 >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11530): https://lists.yoctoproject.org/g/linux-yocto/message/11530 Mute This Topic: https://lists.yoctoproject.org/mt/92599288/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
