On Thu, Oct 6, 2022 at 2:27 PM Bruce Ashfield via
lists.yoctoproject.org
<bruce.ashfield=gmail....@lists.yoctoproject.org> wrote:
>
> On Thu, Oct 6, 2022 at 1:52 PM Bruce Ashfield via
> lists.yoctoproject.org
> <bruce.ashfield=gmail....@lists.yoctoproject.org> wrote:
> >
> > In message: Re: [linux-yocto] [yocto-kernel-tools][PATCH] spp: expand input
> > files when they have full path
> > on 29/09/2022 Bruce Ashfield wrote:
> >
> > > Thanks,
> > >
> > > I'll run this against the builds where I developed the problematic
> > > change. If everything keeps working, the choice is simple .. I'll
> > > merge this and we can all keep moving.
> > >
> > > If something breaks, I'll have a jumping point to try and reproduce
> > > your issue and still keep all three working.
> >
> > After breaking, unbreaking and again breaking some use cases, I came
> > up with a slightly different approach.
> >
> > I've been able to build all my test cases here, but I'd be interested
> > in getting your results before sending it to the list for merge.
> >
>
> Cancel that.
>
> I was just running a final set of tests against the 6.0 kernel, and it
> broke in the same way as before.
>
> I'll follow up again with a new version once I have it sorted out.
I've arrived at a very similar solution as I implemented a few weeks
ago. So I really
need to get a reproducer for your problem, or I'll just continually
break one while fixing
the others.
Is it possible for you to point me at the configuration and steps to
reproduce it ?
Bruce
>
> Bruce
>
> > Bruce
> >
> > >
> > > Bruce
> > >
> > >
> > > On Thu, Sep 29, 2022 at 2:33 PM Jose Quaresma <quaresma.j...@gmail.com>
> > > wrote:
> > > >
> > > > The strip_common_prefix function is changed in a way that they will
> > > > use the expanded path of the input argument.
> > > > There are some changes in the process_file function for the *.cfg files
> > > > only and not none for *.scc, *.patch and *defconfig.
> > > >
> > > > This doesn't work for cases where we have the defconfig files
> > > > provided in the some meta-layer and fail with:
> > > >
> > > > [ERROR]: processing of file /tmp/tmp.8hcr45TMiO failed
> > > >
> > > > The content of the '/tmp/tmp.8hcr45TMiO' file is currently:
> > > > | #
> > > > | # spp v0.8
> > > > | # processed: Thu Sep 29 04:18:21 PM UTC 2022
> > > > | #
> > > > | # This is a preprocessor output file, do not edit
> > > > | #
> > > > | #
> > > > | prefix
> > > > /oe/build/conf/../../layers/meta-lmp/meta-lmp-bsp/recipes-kernel/linux/linux-lmp-dev-mfgtool/imx8mq-evk/defconfig
> > > > | kconf non-hardware
> > > > /oe//build/conf/../../layers/meta-lmp/meta-lmp-bsp/recipes-kernel/linux/linux-lmp-dev-mfgtool/imx8mq-evk/defconfig
> > > > | # run time: 0 seconds
> > > > | # processed files:
> > > > | # _cfg
> > > > /oe//build/conf/../../layers/meta-lmp/meta-lmp-bsp/recipes-kernel/linux/linux-lmp-dev-mfgtool/imx8mq-evk/defconfig
> > > >
> > > > Before commit 9320c2a the prefix is clean:
> > > > | #
> > > > | # spp v0.8
> > > > | # processed: Thu Sep 29 04:15:36 PM UTC 2022
> > > > | #
> > > > | # This is a preprocessor output file, do not edit
> > > > | #
> > > > | #
> > > > | prefix
> > > > | kconf non-hardware
> > > > /oe/build/conf/../../layers/meta-lmp/meta-lmp-bsp/recipes-kernel/linux/linux-lmp-dev-mfgtool/imx8mq-evk/defconfig
> > > > | # run time: 0 seconds
> > > > | # processed files:
> > > > | # _cfg
> > > > /oe/build/conf/../../layers/meta-lmp/meta-lmp-bsp/recipes-kernel/linux/linux-lmp-dev-mfgtool/imx8mq-evk/defconfig
> > > >
> > > > With this patch applied the prefix is clean as before 9320c2a:
> > > > | #
> > > > | # spp v0.8
> > > > | # processed: Thu Sep 29 05:09:21 PM UTC 2022
> > > > | #
> > > > | # This is a preprocessor output file, do not edit
> > > > | #
> > > > | #
> > > > | prefix
> > > > | kconf non-hardware
> > > > /oe/layers/meta-lmp/meta-lmp-bsp/recipes-kernel/linux/linux-lmp-dev-mfgtool/imx8mq-evk/defconfig
> > > > | # run time: 0 seconds
> > > > | # processed files:
> > > > | # _cfg
> > > > /oe/layers/meta-lmp/meta-lmp-bsp/recipes-kernel/linux/linux-lmp-dev-mfgtool/imx8mq-evk/defconfig
> > > >
> > > > Signed-off-by: Jose Quaresma <jose.quare...@foundries.io>
> > > > ---
> > > > tools/spp | 13 ++++++++++++-
> > > > 1 file changed, 12 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/tools/spp b/tools/spp
> > > > index f9bb76b..f379205 100755
> > > > --- a/tools/spp
> > > > +++ b/tools/spp
> > > > @@ -300,8 +300,19 @@ search_include_paths()
> > > > done
> > > > }
> > > >
> > > > +expand_if_full_path()
> > > > +{
> > > > + for i in $@; do
> > > > + if [ "${i:0:1}" = "/" ]; then
> > > > + i=$(readlink -f $i)
> > > > + fi
> > > > + echo $i
> > > > + done
> > > > +}
> > > > +
> > > > +
> > > > # args are the input files
> > > > -infiles=$@
> > > > +infiles=$(expand_if_full_path $@)
> > > >
> > > > processed_files=""
> > > >
> > > > --
> > > > 2.34.1
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > - Thou shalt not follow the NULL pointer, for chaos and madness await
> > > thee at its end
> > > - "Use the force Harry" - Gandalf, Star Trek II
> >
> >
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
>
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#11751):
https://lists.yoctoproject.org/g/linux-yocto/message/11751
Mute This Topic: https://lists.yoctoproject.org/mt/94001124/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
