merged.
Bruce
In message: [linux-yocto][linux-yocto v5.15/standard/sdkv5.10/axxia &
v5.15/standard/preempt-rt/sdkv5.10/axxia][PATCH 1/1] net: nemac: fix
incorrectly return value check
on 11/01/2023 Liwei Song wrote:
> of_get_mac_address() return 0 if successful invoked, wrong check
> with "ret" will cause a randomized MAC address.
>
> Signed-off-by: Liwei Song <liwei.s...@windriver.com>
> ---
> drivers/net/ethernet/intel/axxia/nemac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/axxia/nemac.c
> b/drivers/net/ethernet/intel/axxia/nemac.c
> index 12cbf1bb527c..3e355af17033 100644
> --- a/drivers/net/ethernet/intel/axxia/nemac.c
> +++ b/drivers/net/ethernet/intel/axxia/nemac.c
> @@ -1310,7 +1310,7 @@ nemac_probe(struct platform_device *pdev)
> */
>
> ret = of_get_mac_address(dn, macaddr_dt);
> - if (ret && is_valid_ether_addr(macaddr_dt)) {
> + if (!ret && is_valid_ether_addr(macaddr_dt)) {
> ether_addr_copy(ndev->dev_addr, macaddr_dt);
> } else {
> random_ether_addr(ndev->dev_addr);
> --
> 2.32.0
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#12096):
https://lists.yoctoproject.org/g/linux-yocto/message/12096
Mute This Topic: https://lists.yoctoproject.org/mt/96195775/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
