On 5/16/23 11:00, Bruce Ashfield wrote: > In message: [linux-yocto][linux-yocto v5.15/standard/base][PATCH 1/1] net: > stmmac: Enable mac_managed_pm phylink config > on 15/05/2023 Liwei Song wrote: > >> From: Shenwei Wang <[email protected]> >> >> commit f151c147b3afcf92dedff53f5f0e965414e4fd2c upstream. >> >> Enable the mac_managed_pm configuration in the phylink_config >> structure to avoid the kernel warning during system resume. >> >> Fixes: 744d23c71af3 ("net: phy: Warn about incorrect mdio_bus_phy_resume() >> state") >> Signed-off-by: Shenwei Wang <[email protected]> >> Acked-by: Florian Fainelli <[email protected]> >> Signed-off-by: David S. Miller <[email protected]> > > It would be useful to log how we discovered the issue, i.e > something like: > > [<your initials>: discovered during resume testing on board <xyz>]
Got it, this is discovered during resume testing on board Stratix 10, Will add these kind of log for future patches. Thanks, Liwei. > > But that's for any future patches, I've merged this as-is. > > Bruce > >> Signed-off-by: Liwei Song <[email protected]> >> --- >> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> index a3bd5396c2f8..c0771b67bcad 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> @@ -1284,6 +1284,7 @@ static int stmmac_phy_setup(struct stmmac_priv *priv) >> >> if (!fwnode) >> fwnode = dev_fwnode(priv->device); >> + priv->phylink_config.mac_managed_pm = true; >> >> phylink = phylink_create(&priv->phylink_config, fwnode, >> mode, &stmmac_phylink_mac_ops); >> -- >> 2.35.5 >>
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#12558): https://lists.yoctoproject.org/g/linux-yocto/message/12558 Mute This Topic: https://lists.yoctoproject.org/mt/98898858/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
