In message: [PATCH] media: subdev: Fix the wrong reference of
v4l2_subdev_state::lock
on 19/05/2023 Kevin Hao wrote:
> From: Kevin Hao <kexin....@windriver.com>
>
> The v4l2_subdev_state::lock is a lock pointer, so the additional
> dereferencing operator is not needed. These issues were introduced by
> the following two commits:
> b3ec78e409e0 ("media: subdev: add v4l2_subdev_set_routing helper()")
> 04b09e1e259f ("media: subdev: add stream based configuration")
>
> Signed-off-by: Kevin Hao <kexin....@windriver.com>
> ---
> Hi Bruce,
>
> Please help me merge this into the following two branches:
> v6.1/standard/preempt-rt/ti-sdk-5.10/ti-j7xxx
> v6.1/standard/ti-sdk-5.10/ti-j7xxx
merged.
Bruce
>
> drivers/media/v4l2-core/v4l2-subdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-subdev.c
> b/drivers/media/v4l2-core/v4l2-subdev.c
> index 19c5cfc05bc0..01b44b996891 100644
> --- a/drivers/media/v4l2-core/v4l2-subdev.c
> +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> @@ -1488,7 +1488,7 @@ int v4l2_subdev_set_routing(struct v4l2_subdev *sd,
> struct v4l2_subdev_krouting *dst = &state->routing;
> const struct v4l2_subdev_krouting *src = routing;
>
> - lockdep_assert_held(&state->lock);
> + lockdep_assert_held(state->lock);
>
> kvfree(dst->routes);
> dst->routes = NULL;
> @@ -1538,7 +1538,7 @@ v4l2_state_get_stream_format(struct v4l2_subdev_state
> *state, unsigned int pad,
> struct v4l2_subdev_stream_configs *stream_configs;
> unsigned int i;
>
> - lockdep_assert_held(&state->lock);
> + lockdep_assert_held(state->lock);
>
> stream_configs = &state->stream_configs;
>
> --
> 2.39.2
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#12630):
https://lists.yoctoproject.org/g/linux-yocto/message/12630
Mute This Topic: https://lists.yoctoproject.org/mt/99002748/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe:
https://lists.yoctoproject.org/g/linux-yocto/leave/6687884/21656/624485779/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
