Hi all, On Tue, Jun 6, 2023 at 4:33 PM Clément Péron <[email protected]> wrote:
> Hi, > > On Tue, 6 Jun 2023 at 17:32, Clément Péron via lists.yoctoproject.org > <[email protected]> wrote: > > > > Hi, > > > > On 03/03/2023 17:28, Jon Mason wrote: > > > /ATA > > > > > > On Wed, Mar 1, 2023 at 10:38 AM Bruce Ashfield < > [email protected]> wrote: > > >> > > >> Patch 1/2 looks fine, but 2/2 reverts the following commit: > > >> > > >> ========================== > > >> commit 41751659d0650c4effdd598f26febba39aeaf082 > > >> Author: Andrei Gherzan <[email protected]> > > >> Date: Mon Aug 22 19:55:10 2022 +0200 > > >> > > >> efi.cfg: Drop ACPI dependency > > >> > > >> On X86 this will have no impact as CONFIG_ACPI is enabled by > default. On > > >> the other hand, ARM64 would be affected as they don't have the > same > > >> default. The defconfig for arm64 recommends CONFIG_ACPI and this > patch > > >> follows this recommendation in the qemuarm64 bsp configuration > to fix > > >> ACPI-only EFI boots on this arch. > > >> > > >> arm (32bit) would also be unaffected as there is no ACPI support > there > > >> at all. And this unconditional drop (CONFIG_ACPI) will actually > fix a > > >> configuration warning when enabling EFI on a arm (32bit) machine: > > >> > > >> [INFO]: config 'CONFIG_ACPI' was set, but it wasn't assignable, > check (parent) dependencies > > > > > > What's weird is that I'm not seeing this issue at all, and I'm > > > compiling with and without efi enabled. See > > > > https://git.yoctoproject.org/meta-arm/tree/meta-arm/recipes-kernel/linux/linux-yocto_%25.bbappend > > > > https://git.yoctoproject.org/meta-arm/tree/meta-arm/recipes-kernel/linux/files/efi.cfg > > > > > > with edk2 (uefi) > > > https://gitlab.com/jonmason00/meta-arm/-/jobs/3868649253 > > > without edk2 (using u-boot) > > > https://gitlab.com/jonmason00/meta-arm/-/jobs/3868649241 > > > > > > For giggles, I added the same efi.cfg to qemuarmv5 to see if it would > > > cause an issue (as maybe the sstate is hiding the warnings), and I > > > don't see it there either. Is there a better way than this to > > > replicate it? > > > > > > Also, if this one is holding the other back, feel free to drop and > > > I'll mess with it again later. > > > > +Andrei Gherzan to this mail, > Resent with proper email. > > > > > I'm also facing the same issue, with a qemuarm64 board MACHINE_FEATURES > > have the EFI but it refuses to boot and I needed to manually set > > CONFIG_ACPI as it was missing to my kernel config. > > > > @Andrei could you explain which ACPI-only ARM64 EFI boots would break > > with this patch? > Hard for me to remember the details after so long. I'm pretty sure it was for one of the QEMU EFI machines part of the Oniro project ( https://gitlab.eclipse.org/eclipse/oniro-core/oniro/-/tree/kirkstone/meta-oniro-core/conf/machine). I am not active on that project anymore so I won't be able to assist more with logs and reproducible steps. Still, I'll add Stefan to this thread, who might be able to help. Andrei
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#12739): https://lists.yoctoproject.org/g/linux-yocto/message/12739 Mute This Topic: https://lists.yoctoproject.org/mt/97296889/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
