Indeed!

This is merged to 6.4 and master.

Brue

In message: [PATCH] leds : do not enable CONFIG_LEDS_TRIGGER_GPIO by default
on 20/07/2023 Yogesh Tyagi wrote:

> Following commit marked GPIO LED trigger driver 'broken'from 6.4 onward
> https://github.com/torvalds/linux/commit/8f0adae1cb1a3cf83e38dd435831baa38dd84b4c
> 
> Having CONFIG_LEDS_TRIGGER_GPIO enabled by default is causing below warning 
> during build:
> 
> WARNING: linux-intel-6.4.0+gitAUTOINC+de40822021_9bcda79692-r0 
> do_kernel_configcheck: [kernel config]: specified values did not make it into 
> the kernel's final configuration:
> 
>     [NOTE]: 'CONFIG_LEDS_TRIGGER_GPIO' last val (y) and .config val (n) do 
> not match
>     [INFO]: CONFIG_LEDS_TRIGGER_GPIO : n
>     [INFO]: raw config text:
> 
>         config LEDS_TRIGGER_GPIO
>               tristate "LED GPIO Trigger"
>               depends on (GPIOLIB || COMPILE_TEST) && BROKEN && LEDS_TRIGGERS 
> && NEW_LEDS
>               help
>                 This allows LEDs to be controlled by gpio events. It's good
>                 when using gpios as switches and triggering the needed LEDs
>                 from there. One use case is n810's keypad LEDs that could
>                 be triggered by this trigger when user slides up to show
>                 keypad.
> 
>                 If unsure, say N.
> 
>         Config 'LEDS_TRIGGER_GPIO' has the following Direct dependencies 
> (LEDS_TRIGGER_GPIO=n):
>                 GPIOLIB(=y) || COMPILE_TEST(=n) (=y) && BROKEN(=n) && 
> LEDS_TRIGGERS(=y) && NEW_LEDS(=y)
>         Parent dependencies are:
>              BROKEN [n] LEDS_TRIGGERS [y] COMPILE_TEST [n] GPIOLIB [y] 
> NEW_LEDS [y]
>     [INFO]: config 'CONFIG_LEDS_TRIGGER_GPIO' was set, but it wasn't 
> assignable, check (parent) dependencies
> 
> So let's not enable it by default.
> 
> Signed-off-by: Yogesh Tyagi <yogesh.ty...@intel.com>
> ---
>  features/leds/leds.cfg | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/features/leds/leds.cfg b/features/leds/leds.cfg
> index eb40627c..33f3da76 100644
> --- a/features/leds/leds.cfg
> +++ b/features/leds/leds.cfg
> @@ -13,4 +13,3 @@ CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
>  # Include them here, but they won't be enabled unless GPIO is explicitly
>  # enabled as well.
>  CONFIG_LEDS_GPIO=y
> -CONFIG_LEDS_TRIGGER_GPIO=y
> -- 
> 2.34.1
> 
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#12877): 
https://lists.yoctoproject.org/g/linux-yocto/message/12877
Mute This Topic: https://lists.yoctoproject.org/mt/100253175/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: 
https://lists.yoctoproject.org/g/linux-yocto/leave/6687884/21656/624485779/xyzzy
 [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to