> -----Original Message----- > From: [email protected] <linux- > [email protected]> On Behalf Of Paul Gortmaker via > lists.yoctoproject.org > Sent: Friday, December 1, 2023 03:08 > To: Bruce Ashfield <[email protected]> > Cc: [email protected] > Subject: [linux-yocto] [PATCH 3/5] x86-64: don't force EDAC support on > everyone > > From: Paul Gortmaker <[email protected]> > > Similar to the argument of why we shouldn't force NUMA on everyone, the > 9 chip registered ECC RAM type stuff also tends to be found mostly on > larger server type stuff and less so on embedded targets. > > We already have a skeleton EDAC feature, so move the features over there. > One could argue that we might want to separate into arch specific config > fragments, but to me - that seems overkill at this point in time. > > Signed-off-by: Paul Gortmaker <[email protected]> > --- > bsp/intel-x86/intel-x86-64.cfg | 13 ------------- > features/edac/edac.cfg | 8 ++++++++ > 2 files changed, 8 insertions(+), 13 deletions(-) > > diff --git a/bsp/intel-x86/intel-x86-64.cfg b/bsp/intel-x86/intel-x86- > 64.cfg index f31711e73181..58b0fed637e8 100644 > --- a/bsp/intel-x86/intel-x86-64.cfg > +++ b/bsp/intel-x86/intel-x86-64.cfg > @@ -3,19 +3,6 @@ > # General setup > # > > -# EDAC > -CONFIG_EDAC=y > -CONFIG_EDAC_DEBUG=y > -CONFIG_EDAC_SBRIDGE=m > -CONFIG_ACPI_APEI=y > -CONFIG_ACPI_APEI_EINJ=m > -CONFIG_ACPI_APEI_GHES=y > -CONFIG_EDAC_PND2=m > -CONFIG_EDAC_SKX=m > -CONFIG_EDAC_I10NM=m > -CONFIG_EDAC_IGEN6=m > - > - > # ISH > CONFIG_INTEL_ISH_HID=m > > diff --git a/features/edac/edac.cfg b/features/edac/edac.cfg index > 9b3d3fc59eae..4f75d2f825ee 100644 > --- a/features/edac/edac.cfg > +++ b/features/edac/edac.cfg > @@ -15,3 +15,11 @@ > CONFIG_RAS=y > CONFIG_EDAC=y > CONFIG_EDAC_DEBUG=y > +CONFIG_EDAC_SBRIDGE=m > +CONFIG_ACPI_APEI=y > +CONFIG_ACPI_APEI_EINJ=m > +CONFIG_ACPI_APEI_GHES=y > +CONFIG_EDAC_PND2=m > +CONFIG_EDAC_SKX=m > +CONFIG_EDAC_I10NM=m
Other arch/bsp may include edac.scc. They clearly don't want EDAC drivers for x86 platform. And since CONFIG_EDAC_I10NM depends on X86_64, won't it cause warnings when doing kernel_configcheck for other arch? Thanks, Yongxin > +CONFIG_EDAC_IGEN6=m > -- > 2.40.0
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13341): https://lists.yoctoproject.org/g/linux-yocto/message/13341 Mute This Topic: https://lists.yoctoproject.org/mt/102900653/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
