On 13-01-17 05:19 PM, Kamble, Nitin A wrote:


-----Original Message-----
From: Zanussi, Tom
Sent: Thursday, January 17, 2013 1:49 PM
To: Kamble, Nitin A
Cc: bruce.ashfi...@windriver.com; Hart, Darren; linux-
yo...@yoctoproject.org
Subject: Re: [meta branch v3 02/12] meta: drm-emgd.cfg: add configs for
dependent routines

On Wed, 2013-01-16 at 11:23 -0800, nitin.a.kam...@intel.com wrote:
From: Nitin A Kamble <nitin.a.kam...@intel.com>

emgd driver utilizes common frame buffer routines to implement some of
the tasks. Making sure these routines are turned on in the kernel
config when emgd is selected.

This commit avoids these kind of kernel build errors.

| ERROR: "cfb_fillrect" [drivers/gpu/drm/emgd/emgd.ko] undefined!
| ERROR: "cfb_imageblit" [drivers/gpu/drm/emgd/emgd.ko] undefined!
| ERROR: "cfb_copyarea" [drivers/gpu/drm/emgd/emgd.ko] undefined!


Were you hitting these errors?  I haven't seen them before.

I guess this new set is a copy of a block from drm-psb.cfg, where IIRC I did
see them - should we make that a common fragment instead of having
multiple copies?

This errors show up when emgd driver is enabled without vesafb in the kernel 
config. Earlier
vesafb was satisfying these dependencies for emgd driver. Now emgd is 
configured without vesafb.
   Right, I got them from the drm-psb.cfg. I see other graphics config fragments
include some of these too. So it is possible to move them in a common fragment, 
but with the
current workload I think this cleanup will lower priority.


Also, I guess we don't use the psb stuff any more - should we remove drm-
psb?
I also see no need of the psb config fragment now. I think Bruce would know 
better if it can be
dumped now. May be all these cleanup can be done as part of moving
to the next kernel version repo. That way we will be doing it more efficiently.

Let's leave it in place for 3.4, and (as you suggest), do the cleanup
for the next version. That being said, you can send patches against
linux-yocto-dev now, and I'll stage changes there.

Cheers,

Bruce



Thanks,
Nitin


Tom


And the I2C config bits are added to better support detection of modes
on the monitors.

Signed-off-by: Nitin A Kamble <nitin.a.kam...@intel.com>
---
  .../kernel-cache/features/drm-emgd/drm-emgd.cfg    |   13
+++++++++++++
  1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/meta/cfg/kernel-cache/features/drm-emgd/drm-emgd.cfg
b/meta/cfg/kernel-cache/features/drm-emgd/drm-emgd.cfg
index cb9558d..001460e2 100644
--- a/meta/cfg/kernel-cache/features/drm-emgd/drm-emgd.cfg
+++ b/meta/cfg/kernel-cache/features/drm-emgd/drm-emgd.cfg
@@ -1,3 +1,16 @@
  CONFIG_DRM=y
  CONFIG_DRM_EGD=m
  CONFIG_DRM_KMS_HELPER=m
+
+CONFIG_I2C=y
+CONFIG_VIDEO_V4L2=y
+CONFIG_VIDEO_IVTV=y
+CONFIG_MEDIA_SUPPORT=y
+CONFIG_VIDEO_CAPTURE_DRIVERS=y
+CONFIG_VIDEO_DEV=y
+CONFIG_VIDEO_V4L2_COMMON=y
+CONFIG_I2C_ALGOBIT=y
+CONFIG_FB_CFB_COPYAREA=y
+CONFIG_FB_CFB_IMAGEBLIT=y
+CONFIG_FB_CFB_FILLRECT=y
+CONFIG_VIDEO_FB_IVTV=y



_______________________________________________
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto

Reply via email to