[Re: [linux-yocto] [PATCH 2/8] meta/common-pc: Build Ethernet and Wifi drivers as modules] On 07/09/2013 (Sat 01:22) Darren Hart wrote:
> On Fri, 2013-09-06 at 22:51 -0400, Bruce Ashfield wrote: > > On 13-09-06 7:09 PM, Paul Gortmaker wrote: > > > [[linux-yocto] [PATCH 2/8] meta/common-pc: Build Ethernet and Wifi > > > drivers as modules] On 06/09/2013 (Fri 15:44) Darren Hart wrote: > > > > > >> Keep the kernel size down for the common-pc BSPs and continue standard > > >> practice, building drivers as modules. > > >> > > >> Signed-off-by: Darren Hart <[email protected]> > > >> --- > > >> .../kernel-cache/bsp/common-pc/common-pc-eth.cfg | 10 +++++----- > > >> .../kernel-cache/bsp/common-pc/common-pc-wifi.cfg | 10 +++++----- > > >> 2 files changed, 10 insertions(+), 10 deletions(-) > > >> > > >> diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-eth.cfg > > >> b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-eth.cfg > > >> index 5d5e316..94ca90a 100644 > > >> --- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc-eth.cfg > > >> +++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc-eth.cfg > > >> @@ -1,12 +1,12 @@ > > >> # Common Ethernet networking devices (including QEMU and Common PCs) > > >> CONFIG_NET_CORE=y > > >> CONFIG_ETHERNET=y > > >> -CONFIG_MII=y > > >> +CONFIG_MII=m > > >> CONFIG_NET_VENDOR_BROADCOM=y > > >> -CONFIG_TIGON3=y > > >> +CONFIG_TIGON3=m > > >> CONFIG_NET_VENDOR_ATHEROS=y > > >> -CONFIG_ATL2=y > > >> +CONFIG_ATL2=m > > >> CONFIG_NET_VENDOR_INTEL=y > > >> -CONFIG_E1000=y > > >> +CONFIG_E1000=m > > > > > > The tg3 and e1000 are commonly found in off the shelf dell machines and > > > similar other OEM boxes. The reason they were built in was because we > > > faced no end of users who would build new kernels but not build/install > > > the new modules and/or the initrd stuff with the modules bundled. So > > > they would complain about their build not working on their hardware. > > > > > > I can respect the goal to keep kernel size down, but at the same time, > > > we should not trade off a saving of two pages (8k) at the expense of > > > hundreds of users who assume "defconfig" will boot on their machine. > > > Maybe we can use CONFIG_EXPERT to our advantage in giving you what you > > > want and at the same time, not breaking existing users who don't? > > > > Considering that I like to NFS boot with E1000 nics, having it > > built in makes life a whole lot simpler. I'd not be as concerned > > about the wifi drivers, but I'm largely in agreement here, I'd > > rather see the wired drivers built in. > > Fair enough. Shall we leave E1000 and TIGON3 as Y and everything else as > M? Any objection to the wifi as M? I've also made PCNET32=y for qemu > machines that may nfs boot. Sounds good to me. I don't envision nfs root over wifi happening too often. :) P. -- > > I've made these changes and pushed it to the contrib branch. > > -- > Darren Hart > Intel Open Source Technology Center > Yocto Project - Linux Kernel > > > _______________________________________________ > linux-yocto mailing list > [email protected] > https://lists.yoctoproject.org/listinfo/linux-yocto _______________________________________________ linux-yocto mailing list [email protected] https://lists.yoctoproject.org/listinfo/linux-yocto
