> -----Original Message----- > From: [email protected] [mailto:linux-yocto- > [email protected]] On Behalf Of Darren Hart > Sent: Tuesday, September 24, 2013 12:19 PM > To: Development list for the linux-yocto*.git Linux kernel repositories > Subject: Re: [linux-yocto] [PATCH 1/2] features/power/intel.cfg: convert to > modules > > On Tue, 2013-09-24 at 18:23 +0000, [email protected] wrote: > > From: Nitin A Kamble <[email protected]> > > > > Convert all the "y" to "m" which can be converted. > > We have been doing this for drivers as they may or may not be useful on a > given machine. However.... what is the motivation for converting these to > modules? Are these options not applicable to any BSP that includes intel.cfg? > Is there some significant size savings here?
This is not a strictly required change. As you mentioned that for genericx86 BSPs bunch of kernel config options are getting converted from "y" to "m". So, as I was going through these configs, and could do the conversion easily alongside the resume fix. I did not measure the impact on the kernel size, my guess is, not a significant savings through these conversions. So I am ok, if this commit is not accepted. Thanks, Nitin > > -- > Darren > > > > > Signed-off-by: Nitin A Kamble <[email protected]> > > --- > > meta/cfg/kernel-cache/features/power/intel.cfg | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/meta/cfg/kernel-cache/features/power/intel.cfg > > b/meta/cfg/kernel-cache/features/power/intel.cfg > > index 80ccbd9..b51c881 100644 > > --- a/meta/cfg/kernel-cache/features/power/intel.cfg > > +++ b/meta/cfg/kernel-cache/features/power/intel.cfg > > @@ -9,12 +9,12 @@ CONFIG_INOTIFY_USER=y > > > > # enable cpu frequency scaling and stats for powertop > > CONFIG_CPU_FREQ=y -CONFIG_CPU_FREQ_STAT=y - > CONFIG_CPU_FREQ_TABLE=y > > -CONFIG_X86_ACPI_CPUFREQ=y - > CONFIG_CPU_FREQ_GOV_ONDEMAND=y > > -CONFIG_CPU_FREQ_GOV_PERFORMANCE=y > > -CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y > > +CONFIG_CPU_FREQ_STAT=m > > +CONFIG_CPU_FREQ_TABLE=m > > +CONFIG_X86_ACPI_CPUFREQ=m > > +CONFIG_CPU_FREQ_GOV_ONDEMAND=m > > +CONFIG_CPU_FREQ_GOV_PERFORMANCE=m > > +CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=m > > > > # enable power management debugging for tools like powertop > > CONFIG_PM_DEBUG=y > > -- > Darren Hart > Intel Open Source Technology Center > Yocto Project - Linux Kernel > > > _______________________________________________ > linux-yocto mailing list > [email protected] > https://lists.yoctoproject.org/listinfo/linux-yocto _______________________________________________ linux-yocto mailing list [email protected] https://lists.yoctoproject.org/listinfo/linux-yocto
