On Tue, Sep 29, 2015 at 10:18:00AM -0700, Khem Raj wrote:
> 
>     On Sep 29, 2015, at 3:01 AM, Burton, Ross <[email protected]> wrote:
> 
> 
>     On 29 September 2015 at 10:42, Kevin Hao <[email protected]> wrote:
> 
>         Boot test for all these boards.
> 
> 
>     If I build the edgerouter kernel I get this warning:
> 
>     WARNING: Section not found: .comment
> 
>     I've no idea if this is bad or not…
> 
> 
> functionally no harm since its the strip code which is complaining about it so
> this section was going to go away from kernel image anyway
> it seems we must have included .comment in KERNEL_IMAGE_STRIP
> 
> Now the more curious case would be if its being stripped by kernel build, we
> explicitly disabled kernel build stripping the kernel image
> and here it might be thats not happening with new kernel. That aspect could be
> investigated.

Actually the warning is a bug in the do_strip() of kernel build. The vmlinux
image does have the .comment section, but the code that checking if the
.comment section is existed is wrong. Please see the following codes in
do_strip():

                for str in ${KERNEL_IMAGE_STRIP_EXTRA_SECTIONS}; do {
                        if [ "$headers" != *"$str"* ]; then
                                bbwarn "Section not found: $str";
                        fi

                        "$CROSS_COMPILE"strip -s -R $str ${KERNEL_OUTPUT}
                }; done


The "*" doesn't have special meaning in the if string test. So it will return
true even the $str is a substring of $headers. How about change the test to:

                        if ! (echo "$headers" | grep -q "^$str$"); then

Thanks,
Kevin

Attachment: pgpKfksBIKkfW.pgp
Description: PGP signature

-- 
_______________________________________________
linux-yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/linux-yocto

Reply via email to