[[linux-yocto] [PATCH 01/13] features/debug: add debug-kernel feature] On 04/02/2016 (Thu 16:25) California Sullivan wrote:
> Since EMBEDDED, EXPERT, and DEBUG_KERNEL are being removed from the base > ktype, we can no longer assume DEBUG_KERNEL is enabled. > > Also add this fragment to features that require DEBUG_KERNEL. > > Signed-off-by: California Sullivan <[email protected]> > --- > features/debug/debug-kernel.cfg | 2 ++ > features/debug/debug-kernel.scc | 6 ++++++ > features/debug/printk.scc | 1 + > features/latencytop/latencytop.scc | 3 +++ > features/profiling/profiling.scc | 2 ++ > 5 files changed, 14 insertions(+) > create mode 100644 features/debug/debug-kernel.cfg > create mode 100644 features/debug/debug-kernel.scc > > diff --git a/features/debug/debug-kernel.cfg b/features/debug/debug-kernel.cfg > new file mode 100644 > index 0000000..96a7954 > --- /dev/null > +++ b/features/debug/debug-kernel.cfg > @@ -0,0 +1,2 @@ > +CONFIG_DEBUG_KERNEL=y > +CONFIG_DEBUG_INFO=y I wonder if this is a good time and place to also call out DEBUG_PREEMPT and some of the MUTEX options explictly ; currently we rely on the "default y" in Kconfig for some, but the importance in -rt kernels to help catch incorrect processor_id and sleeping while atomic validations is critical to BSP and driver development on -rt ; such that IMHO it is worth giving them explicit status in this file while we are creating it. Also... > diff --git a/features/debug/debug-kernel.scc b/features/debug/debug-kernel.scc > new file mode 100644 > index 0000000..a4527dc > --- /dev/null > +++ b/features/debug/debug-kernel.scc > @@ -0,0 +1,6 @@ > + > +define KFEATURE_DESCRIPTION "Enable debug kernel" > +define KFEATURE_COMPATIBILITY all > + > +kconf non-hardware debug-kernel.cfg > + > diff --git a/features/debug/printk.scc b/features/debug/printk.scc > index d592605..3526dea 100644 > --- a/features/debug/printk.scc > +++ b/features/debug/printk.scc > @@ -8,3 +8,4 @@ define KFEATURE_COMPATIBILITY all > > kconf non-hardware printk.cfg > > +include debug-kernel.scc > diff --git a/features/latencytop/latencytop.scc > b/features/latencytop/latencytop.scc > index 923b5d9..af59e24 100644 > --- a/features/latencytop/latencytop.scc > +++ b/features/latencytop/latencytop.scc > @@ -1,4 +1,7 @@ > + > define KFEATURE_DESCRIPTION "Enable latencytop" > define KFEATURE_COMPATIBILITY arch > > kconf non-hardware latencytop.cfg > + > +include features/debug/debug-kernel.scc I'm OK with adding whitespace for consistency, but then ... > diff --git a/features/profiling/profiling.scc > b/features/profiling/profiling.scc > index 32032fa..f0715e1 100644 > --- a/features/profiling/profiling.scc > +++ b/features/profiling/profiling.scc > @@ -1,3 +1,5 @@ > +include features/debug/debug-kernel.scc > + > define KFEATURE_DESCRIPTION "Enable profiling and timerstats" > define KFEATURE_COMPATIBILITY board > ... you put the include at the top instead of at the bottom, which is inconsistent with all the other entries. Paul. -- > -- > 2.5.0 > > -- > _______________________________________________ > linux-yocto mailing list > [email protected] > https://lists.yoctoproject.org/listinfo/linux-yocto -- _______________________________________________ linux-yocto mailing list [email protected] https://lists.yoctoproject.org/listinfo/linux-yocto
