From: Rajneesh Bhardwaj <[email protected]> commit 1f644da7e920cb83403818efa88ebfb6d1528264 upstream.
Symbolic permissions 'S_IRUGO' are not preferred. This patch changes the debugfs files to use octal permissions '0644' or '0444' as needed by the attribute. Signed-off-by: Srinivas Pandruvada <[email protected]> Signed-off-by: Rajneesh Bhardwaj <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Liwei Song <[email protected]> --- drivers/platform/x86/intel_pmc_core.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c index 44353034718a..cf8b3b34a979 100644 --- a/drivers/platform/x86/intel_pmc_core.c +++ b/drivers/platform/x86/intel_pmc_core.c @@ -414,31 +414,27 @@ static int pmc_core_dbgfs_register(struct pmc_dev *pmcdev) return -ENOMEM; pmcdev->dbgfs_dir = dir; - file = debugfs_create_file("slp_s0_residency_usec", S_IFREG | S_IRUGO, + file = debugfs_create_file("slp_s0_residency_usec", 0444, dir, pmcdev, &pmc_core_dev_state); if (!file) goto err; - file = debugfs_create_file("pch_ip_power_gating_status", - S_IFREG | S_IRUGO, dir, pmcdev, - &pmc_core_ppfear_ops); + file = debugfs_create_file("pch_ip_power_gating_status", 0444, + dir, pmcdev, &pmc_core_ppfear_ops); if (!file) goto err; - file = debugfs_create_file("mphy_core_lanes_power_gating_status", - S_IFREG | S_IRUGO, dir, pmcdev, - &pmc_core_mphy_pg_ops); + file = debugfs_create_file("mphy_core_lanes_power_gating_status", 0444, + dir, pmcdev, &pmc_core_mphy_pg_ops); if (!file) goto err; - file = debugfs_create_file("pll_status", - S_IFREG | S_IRUGO, dir, pmcdev, + file = debugfs_create_file("pll_status", 0444, dir, pmcdev, &pmc_core_pll_ops); if (!file) goto err; - file = debugfs_create_file("ltr_ignore", - S_IFREG | S_IRUGO, dir, pmcdev, + file = debugfs_create_file("ltr_ignore", 0644, dir, pmcdev, &pmc_core_ltr_ignore_ops); if (!file) -- 2.7.4 -- _______________________________________________ linux-yocto mailing list [email protected] https://lists.yoctoproject.org/listinfo/linux-yocto
