On Wed, Oct 9, 2019 at 9:39 AM Michal Simek <michal.si...@xilinx.com> wrote:
>
> Hi,
>
> On 09. 10. 19 4:38, quanyang.w...@windriver.com wrote:
> > From: Quanyang Wang <quanyang.w...@windriver.com>
> >
> > Using new compatible value for funnel and replicator device nodes,
> > and use correct unit-address.
> >
> > Signed-off-by: Quanyang Wang <quanyang.w...@windriver.com>
> > ---
> >  arch/arm/boot/dts/zynq-7000.dtsi | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/zynq-7000.dtsi 
> > b/arch/arm/boot/dts/zynq-7000.dtsi
> > index 5602f4f3ad1c..9b8f46d25d38 100644
> > --- a/arch/arm/boot/dts/zynq-7000.dtsi
> > +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> > @@ -447,8 +447,8 @@
> >                       };
> >               };
> >
> > -             funnel@0,f8804000 {
> > -                     compatible = "arm,coresight-funnel", "arm,primecell";
> > +             funnel@f8804000 {
> > +                     compatible = "arm,coresight-static-funnel", 
> > "arm,primecell";
> >                       reg = <0xf8804000 0x1000>;
> >                       clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> >                       clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
> > @@ -503,7 +503,7 @@
> >               };
> >
> >               replicator {
> > -                     compatible = "arm,coresight-replicator";
> > +                     compatible = "arm,coresight-static-replicator";
> >                       clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> >                       clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
> >
> > @@ -536,8 +536,8 @@
> >                       };
> >               };
> >
> > -             itm@0,f8805000 {
> > -                     compatible = "arm,coresight-etm3x", "arm,primecell";
> > +             /* ITM is not supported by kernel, only leave device node 
> > here */
> > +             itm@f8805000 {
> >                       reg = <0xf8805000 0x1000>;
> >                       clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> >                       clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
> > @@ -549,7 +549,7 @@
> >                       };
> >               };
> >
> > -             ptm@0,f889c000 {
> > +             ptm@f889c000 {
> >                       compatible = "arm,coresight-etm3x", "arm,primecell";
> >                       reg = <0xf889c000 0x1000>;
> >                       clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> > @@ -562,7 +562,7 @@
> >                       };
> >               };
> >
> > -             ptm@0,f889d000 {
> > +             ptm@f889d000 {
> >                       compatible = "arm,coresight-etm3x", "arm,primecell";
> >                       reg = <0xf889d000 0x1000>;
> >                       clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
> >
>
>
> I don't think this is enough. I have attached the patch against mainline
> how I think it should look like.

Crap. I was a minute too early. I've reverted what I queued and will
wait for a v2.

Bruce

>
> M
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
-- 
_______________________________________________
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto

Reply via email to