Hi Sascha, On Sat, Mar 16, 2013 at 12:14:58AM +0100, Sascha Herrmann wrote: > In at86rf230_probe() lp was first set to dev->priv and a few lines later > dev->priv was set to lp again, without changing lp in between. The call > to ieee802154_unregister_device() before err_irq: was unreachable. The > last call which could fail before this line is the call to > ieee802154_register_device(). > > Signed-off-by: Sascha Herrmann <sas...@ps.nvbi.de> > --- > drivers/net/ieee802154/at86rf230.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ieee802154/at86rf230.c > b/drivers/net/ieee802154/at86rf230.c > index fc1687e..bb5d37d 100644 > --- a/drivers/net/ieee802154/at86rf230.c > +++ b/drivers/net/ieee802154/at86rf230.c > @@ -791,7 +791,6 @@ static int at86rf230_probe(struct spi_device *spi) > > lp->spi = spi; > > - dev->priv = lp; > dev->parent = &spi->dev; > dev->extra_tx_headroom = 0; > /* We do support only 2.4 Ghz */ > @@ -893,7 +892,6 @@ static int at86rf230_probe(struct spi_device *spi) > > return rc; > > - ieee802154_unregister_device(lp->dev); This is a hint for future implementation to set a label before and don't forget to remove this device.
Alex ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
