From: Alexander Smirnov <alex.bluesman.smir...@gmail.com>
Date: Mon, 19 Dec 2011 19:33:44 +0300

> +netdev_tx_t mac802154_tx(struct mac802154_priv *priv, struct sk_buff *skb,
> +                                                     u8 page, u8 chan);

Line up these arguments on the second line correctly!

If you can't do it properly by hand, use something like emacs's "C
mode" to do it for you automatically.

> +             res = xw->priv->ops->set_channel(&xw->priv->hw,
> +                             xw->page,
> +                             xw->chan);

Line up the arguments properly.

> +                     pr_debug("(%s): set_channel failed\n", __func__);

Putting __func__ into the debugging printk's is excessive, take these out.

> +     if (WARN_ON(!(priv->phy->channels_supported[page] &
> +                                     (1 << chan))))

More poor formatting.

------------------------------------------------------------------------------
Learn Windows Azure Live!  Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for 
developers. It will provide a great way to learn Windows Azure and what it 
provides. You can attend the event by watching it streamed LIVE online.  
Learn more at http://p.sf.net/sfu/ms-windowsazure
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel

Reply via email to