On 24/02/12 13:02, Prajosh Premdas wrote:
> From: Felix Varghese <felixvarg...@gmail.com>
>
> Added #defines for MAC PIB attribute ids and default values for PIB attributes
Unnecessary whitespace changes. Unused constants. Camel case. NAK.
Please add constants together with code that will use them.
>
> Signed-off-by: Felix Varghese <felixvarg...@gmail.com>
> Signed-off-by: Prajosh Premdas <premdas.praj...@gmail.com>
> ---
> include/net/ieee802154.h | 148
> ++++++++++++++++++++++++++++++++++++++++++----
> 1 files changed, 137 insertions(+), 11 deletions(-)
>
> diff --git a/include/net/ieee802154.h b/include/net/ieee802154.h
> index ee59f8b..5134f13 100644
> --- a/include/net/ieee802154.h
> +++ b/include/net/ieee802154.h
> @@ -63,15 +63,137 @@
> #define IEEE802154_MFR_SIZE 2 /* 2 octets */
[skip]
> +
> +/* Section 6.4.2 of IEEE 802.15.4 Spec : PHY PIB attributes */
> +#define phyCurrentChannel (0x00)
> +#define phyChannelsSupported (0x01)
> +#define phyTransmitPower (0x02)
> +#define phyCCAMode (0x03)
> +#define phyCurrentPage (0x04)
> +#define phyMaxFrameDuration (0x05)
> +#define phySHRDuration (0x06)
> +#define phySymbolsPerOctet (0x07)
> +#define PHY_OVERHEAD (5)
Drop this. Please.
> +
> +/* Section 7.4.2 of IEEE 802.15.4 Spec : MAC PIB Attributes */
> +#define macIeeeAddress (0xF0)
And attribute 0xf0 didn't get its way into standard, AFAIK. So if you
add them only per standard, you don't / can't use this.
>
> /*
> * The return values of MAC operations
> @@ -157,10 +279,14 @@ enum {
> * A request to perform a scan operation failed because the MLME was
> * in the process of performing a previously initiated scan operation.
> */
> + IEEE802154_READ_ONLY = 0xfb,
> + /*
> + * A request to perform a scan operation failed because the MLME was
> + * in the process of performing a previously initiated scan operation.
> + */
> IEEE802154_SCAN_IN_PROGRESS = 0xfc,
> };
WTF???
--
With best wishes
Dmitry
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
