On 01/29/2013 06:10 PM, Sascha Herrmann wrote:
> thanks for your answer and sorry for my late replay.
No need to apologize.
> Is this what you suggested? :
>
> diff --git a/drivers/net/ieee802154/at86rf230.c
> b/drivers/net/ieee802154/at86rf230.c
> index a4a62e1..369299b 100644
> --- a/drivers/net/ieee802154/at86rf230.c
> +++ b/drivers/net/ieee802154/at86rf230.c
> @@ -31,13 +31,14 @@
> #include <linux/spi/spi.h>
> #include <linux/spi/at86rf230.h>
> #include <linux/skbuff.h>
> +#include <linux/irq.h>
>
> #include <net/mac802154.h>
> #include <net/wpan-phy.h>
>
> struct at86rf230_local {
> struct spi_device *spi;
> - int rstn, slp_tr, dig2;
> + int rstn, slp_tr, dig2, irq_type;
>
> u8 part;
> u8 vers;
> @@ -774,6 +775,7 @@ static int at86rf230_fill_data(struct spi_device *spi)
> lp->rstn = pdata->rstn;
> lp->slp_tr = pdata->slp_tr;
> lp->dig2 = pdata->dig2;
> + lp->irq_type = pdata->irq_type;
>
> return 0;
> }
> @@ -892,6 +894,12 @@ static int at86rf230_probe(struct spi_device *spi)
> if (rc)
> goto err_gpio_dir;
>
> + if (lp->irq_type) {
> + rc = irq_set_irq_type(spi->irq, lp->irq_type);
> + if (rc)
> + goto err_gpio_dir;
> + }
> +
> rc = request_irq(spi->irq, at86rf230_isr, IRQF_SHARED,
> dev_name(&spi->dev), lp);
> if (rc)
> diff --git a/include/linux/spi/at86rf230.h b/include/linux/spi/at86rf230.h
> index b2b1afb..f4a06d8 100644
> --- a/include/linux/spi/at86rf230.h
> +++ b/include/linux/spi/at86rf230.h
> @@ -26,6 +26,7 @@ struct at86rf230_platform_data {
> int rstn;
> int slp_tr;
> int dig2;
> + int irq_type;
> };
>
> #endif
>
This is exactly what I meant. There's no reason to store it in the
at86rf230_local struct though, since it's only ever used in
at86rf230_probe().
I'd add a comment on irq_type to tell what it's expecting (IRQ_TYPE_*).
Alan.
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
