Hi!

Nope. The patch fixes a problem in code that is not in mainline yet. However, 
people on the linux-zigbee mailing list found it a good idea to commit this 
change to mainline to avoid the problem from arising.

I see, you disagree. Nevermind. ;)


Bastian
-- 
Wolf-Bastian Pöttner      Institut für Betriebssysteme & Rechnerverbund
Tel.: +49-531-391-3265                           Mühlenpfordtstrasse 23
Fax.: +49-531-391-5936         TU Braunschweig     D-38106 Braunschweig

Am 13.03.2013 um 15:38 schrieb David Miller <da...@davemloft.net>:

> From: Wolf-Bastian Pöttner <poett...@ibr.cs.tu-bs.de>
> Date: Wed, 13 Mar 2013 08:50:54 +0100
> 
>> offset has to be initialized, otherwise the *first* fragment will
>> be discarded and reassembly cannot happen.
>> 
>> Reviewed-by: Alan Ott <a...@signal11.us>
> 
> 'offset' is never used unless lowpan_fetch_skb_u8(skb, &offset)
> succeeds, in which case it will be initialized properly.  Otherwise we
> unlock and drop the SKB and make no references whatsoever to 'offset'.
> 
> I suspect you saw some compiler warning about 'offset' being
> uninitialized, and are just blindly trying to shut this warning up.


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel

Reply via email to