On 03/17/2013 06:24 PM, Alexander Aring wrote:
> Hi Alan,
>
> On Sun, Mar 17, 2013 at 05:38:00PM -0400, Alan Ott wrote:
>> On 03/17/2013 04:40 PM, Alexander Aring wrote:
>>> Hi Alan,
>>>
>>> On Sun, Mar 17, 2013 at 04:16:08PM -0400, Alan Ott wrote:
>>>> On 12/21/2012 12:37 AM, Alexander Aring wrote:
>>>>> Check for python2.x at first.
>>>>>
>>>>> test_DQ.py works with python2.x only.
>>>>> 'make install' needs python2.x to generate *.pyc files.
>>>>>
>>>>> Signed-off-by: Alexander Aring <alex.ar...@gmail.com>
>>>>> ---
>>>>> configure.ac | 3 +++
>>>>> 1 file changed, 3 insertions(+)
>>>>>
>>>>> diff --git a/configure.ac b/configure.ac
>>>>> index c483b4f..6c9f54b 100644
>>>>> --- a/configure.ac
>>>>> +++ b/configure.ac
>>>>> @@ -77,6 +77,9 @@ AC_PROG_LIBTOOL
>>>>> AM_PROG_LEX
>>>>> AC_PROG_YACC
>>>>> AC_SUBST(LIBTOOL_DEPS)
>>>>> +# Currently the scripts works with python2.x only
>>>>> +# Check for this at first
>>>>> +AC_PATH_PROG(PYTHON, python2 python2.7 python2.6 python2.5 python)
>>>> It looks like you want AC_PATH_PROGS instead.
>>>>
>>>> Also, I'm not really a python guy, but it seems like we might want a
>>>> more thorough solution in addition to this. Can the scripts be made to
>>>> work on both python versions, or is this out of the question? Should
>>>> they be upgraded to python 3?
>>>>
>>>> Again, I don't really do any python, so let me know what the right
>>>> answers are.
>>>>
>>> I am not a python guy, too. The current tests are for python2 and don't
>>> run under python3. A upgrade to python3 is fine, but I have no knowledge
>>> about this. It's good to put this on a TODO list.
>> I did a quick test and it turns out that even print statements are
>> different in Python 3.
>>
>> print "text"
>> vs
>> print("text")
>>
> Ok :/ I can change that and send a patch for it.
>
I'd hold off, I bet there's quite a bit more to it than that. My point
was that even something as basic as the print statement had changed, and
who knows what else if they changed stuff that fundamental.
I just pushed a macro to check the python major version and fail if it's
not 2. I changed my default version here, and it seems to find version 2
and work properly.
Alan.
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
