On Thu, 2013-03-07 at 21:13 +0100, Alexander Aring wrote: > The function addrconf_ifid_eui64 will copy eui into dev->dev_addr. > We need first to manipulate eui[0] before we call memcpy afterwards.
memcpy() does not work that way. > Broken since commit: > 5e98a36ed4bf6ea396170e3af0dd4fcbe51d772f > > Since this commit I got many trouble with the ieee802154 stack. Your change is effectively reverting that commit. Ben. > Signed-off-by: Alexander Aring <alex.ar...@gmail.com> > --- > net/ipv6/addrconf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index fa36a67..4460237 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -1731,8 +1731,8 @@ static int addrconf_ifid_eui64(u8 *eui, struct > net_device *dev) > { > if (dev->addr_len != IEEE802154_ADDR_LEN) > return -1; > - memcpy(eui, dev->dev_addr, 8); > eui[0] ^= 2; > + memcpy(eui, dev->dev_addr, 8); > return 0; > } > -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. ------------------------------------------------------------------------------ Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel