>> I would be happy about any comments :) > > This definitely sounds like a very good idea to me. > > I'm not sure whether the state change (to RX_ON) that's still > being commanded in at86rf230_start after transmit completion is > harmless. I'd consider getting rid of it. > > Unless I was horribly mistaken about RX_SAFE_MODE in > http://www.mail-archive.com/linux-zigbee-devel@lists.sourceforge.net/msg00587.html > you may not need the call to at86rf230_start at all.
I think you are right here, I had the setting of RX_SAFE_MODE removed in an earlier version, too. If I understand this right, we only need to set RX_SAFE_MODE after reading the frame buffer. I fear your thoughts about the race condition with the double reading of the frame buffer are true too. I will try to get some time to work on this. > By the way, if you're looking for speedups, you may also want to > consider converting some at86rf230_write_subreg calls to > __at86rf230_write. E.g., you can write TRX_STATE without masking > TRAC_STATUS. Good point, I didn't recognize, that TRAC_STATUS is read only. Thanks, Sascha -- Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread! ------------------------------------------------------------------------------ Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
