I wrote: > To achieve perfection, at86rf230_probe could try all four > possible trigger modes, pick one the platform supports, and > set TRX_CTRL_1.IRQ_POLARITY accordingly.
Thinking of it, probing by trying request_irq has an unpleasant ring to it. Perhaps a better way would be to leave this decision to the platform code and do one of these: 1) pass irqflags and the polarity in the platform data, or 2) pass irqflags and extract the polarity from the irqflags, or 3) set up the trigger mode outside the driver and pass only the polarity, where 1) with (irqflags & IRQF_TRIGGER_MASK) == 0 includes case 3). - Werner ------------------------------------------------------------------------------ Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
