On 2013年04月25日 16:10, David Miller wrote: > From: Chen Gang <gang.c...@asianux.com> > Date: Tue, 23 Apr 2013 19:24:36 +0800 > >> > >> > Need change ~(u8)0 to 0xff, or in mac802154_wpan_xmit(), "u8 chan" >> > will never == MAC802154_CHAN_NONE. >> > >> > The related warning: >> > net/mac802154/wpan.c:325:2: warning: comparison is always false >> > due to limited range of data type [-Wtype-limits] >> > >> > The related unit test: >> > cc -Wall -O2 -o test test.c >> > ./test >> > will output 'different' >> > >> > (after use '0xff' instead of '~(u8)0', it will output 'equal') > ... >> > Signed-off-by: Chen Gang <gang.c...@asianux.com> > This change belong in the 'net' tree, but your patch won't apply > cleanly there as this part of the header file looks slightly > different there. > > Please respin your patch against 'net' and resubmit, thank you. >
Excuse me, my English is not quite well, I guess your meaning is: send patch v4, and change the subject to "[PATCH v4] mac802154: comparision issue of type cast, finding by EXTRA_CFLAGS=-W". Is it correct ? (the change is for net/mac802154/mac802154.h, and exist in v3.9-rc8) Thanks. -- Chen Gang Asianux Corporation ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
