Hi Werner, On Wed, Jul 24, 2013 at 10:25:03AM -0300, Werner Almesberger wrote: > Alexander Aring wrote: > > +#define is_addr_link_local(a) (((a)->s6_addr16[0]) == htons(0xFE80) && > > \ > > + (((a)->s6_addr16[1]) == 0) && \ > > + (((a)->s6_addr16[2]) == 0) && \ > > + (((a)->s6_addr16[3]) == 0)) > > More parenthesis paranoia: the (a) is good and so are the outermost > parentheses. The ones around the tests for equality are a pascalism > (alas, rather common). The ones around (a)->s6_addr16[*] are just > weird. >
Ok, I don't like it myself, but then I can fix it for all macros that checks is_addr_XXXX. I use the same style for this... So should I change it only for this or for all macros? - Alex ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
