Alexander Aring wrote: > This patch removes some magic number. > Instead of magic numbers we use some defines.
This may be misunderstood. When I read it, my first question was in which other patch you defined MAC802154_FRAME_HARD_HEADER_LEN. But of course, it already exists. So I'd say something like This patch replaces a redundant open-coded calculation with the already defined MAC802154_FRAME_HARD_HEADER_LEN. > Acked-by: Werner Almesberger <wer...@almesberger.net> By the way, you should use the Acked-by only on patches I've seen. While we discussed many things, I didn't comment on all of them. Well, I probably will eventually, so it's hypothetical in this case. - Werner ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
