Alexander Aring wrote:
> static int lowpan_give_skb_to_devices(struct sk_buff *skb)
Oh, and you may want to change (in the patch that changes the loop)
the name to lowpan_give_skb_to_device, since we're (almost) sure
it's exactly one :)
I'd also mention in the description of this patch (i.e., the one
after you've changed the loop) that you're changing the semantics
of lowpan_process_data from copying the skb to consuming it. It's
clear from the code that this is happening but it's reassuring for
reviewers to see it also mentioned in the description because they
then know that you've made sure all users of lowpan_process_data
follow the change.
> @@ -1043,23 +1024,9 @@ lowpan_process_data(struct sk_buff *skb)
> /* UDP data uncompression */
> if (iphc0 & LOWPAN_IPHC_NH_C) {
> struct udphdr uh;
> - struct sk_buff *new;
> if (lowpan_uncompress_udp_header(skb, &uh))
> goto drop;
While you're busy deleting, you may use the opportunity to put a
blank line between the variables and the rest of the function.
The rest looks good. That's a lot of copying you killed there ;-)
- Werner
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
