Hi Werner, On Thu, Oct 24, 2013 at 11:16:19AM -0300, Werner Almesberger wrote: > Alexander Aring wrote: > > Subject: [Linux-zigbee-devel] [PATCH net-next 11/12] 6lowpan: set 6lowpan > > network and transport header > > Acked-by: Werner Almesberger <wer...@almesberger.net> > > (not "reviewed" since I didn't try to hunt down the uses.) > > It seems to me that 08/12, 10/12, 11/12, and 12/12 would make a > nice patch set on their own. They're no longer "trivial" in the > sense that one can see with just one look that they're correct, > and they together clean up and extend the use of skb_*_header > okay I remove these patches from this patchstack, the most benefit is that we don't have the static calculation from the mac header. The mac_header size depends on the flow control which isn't evaluate.
But with this patch we set the mac header size and evaluate the fc for that. For example, the current size matches only for intra pan communication and I remember boardcasting/muticasting is a problem too, because this size calculation is only for EUI64 addresses so parsing of header will failed. (A broadcast address is short-address 0xffff) Another point is that we calculate every offset with the mac_len but we can get the pointers for network_header, mac_header if we set this once. - Alex ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
