From: Joe Perches <j...@perches.com>
Date: Thu, 24 Oct 2013 20:40:51 -0700
> On Fri, 2013-10-25 at 07:28 +0400, Alexander Smirnov wrote:
>> > 25 окт. 2013 г., в 0:51, Alexander Aring <alex.ar...@gmail.com> написал(а):
> []
>> > diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
> []
>> > @@ -440,7 +440,6 @@ lowpan_uncompress_udp_header(struct sk_buff *skb,
>> > struct udphdr *uh)
>> > default:
>> > pr_debug("ERROR: unknown UDP format\n");
>> > goto err;
>> > - break;
>> > }
>> >
>>
>> It's not an unnecessary, it's let say a "good coding practice" to have a
>> break for every case including default.
>
> Hello Alexanders:
>
> Some would otherwise say it's a poor practice.
I think with a goto there at the end of the case statement, it's redundant
and stupid, and thus should be removed.
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
