Hi,
On Mon, Feb 10, 2014 at 10:16:26AM -0800, Eric Dumazet wrote:
> On Mon, 2014-02-10 at 18:33 +0100, Alexander Aring wrote:
> > Hi Eric,
> >
> > On Sun, Feb 09, 2014 at 04:41:47AM -0800, Eric Dumazet wrote:
> > >
> > > Please try the following fix, thanks for this report !
> > >
> > > diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
> > > index 48b25c0af4d0..069af33013c4 100644
> > > --- a/net/ieee802154/6lowpan.c
> > > +++ b/net/ieee802154/6lowpan.c
> > > @@ -533,7 +533,27 @@ static struct header_ops lowpan_header_ops = {
> > > .create = lowpan_header_create,
> > > };
> > >
> > > +static struct lock_class_key lowpan_tx_busylock;
> > > +static struct lock_class_key lowpan_netdev_xmit_lock_key;
> > > +
> > > +static void lowpan_set_lockdep_class_one(struct net_device *dev,
> > > + struct netdev_queue *txq,
> > > + void *_unused)
> > > +{
> > > + lockdep_set_class(&txq->_xmit_lock,
> > > + &lowpan_netdev_xmit_lock_key);
> > > +}
> > > +
> > > +
> > > +static int lowpan_dev_init(struct net_device *dev)
> > > +{
> > > + netdev_for_each_tx_queue(dev, lowpan_set_lockdep_class_one, NULL);
> > > + dev->qdisc_tx_busylock = &lowpan_tx_busylock;
> > > + return 0;
> > > +}
> > > +
> > > static const struct net_device_ops lowpan_netdev_ops = {
> > > + .ndo_init = lowpan_dev_init,
> > > .ndo_start_xmit = lowpan_xmit,
> > > .ndo_set_mac_address = lowpan_set_address,
> > > };
> >
> > thanks, this fixed the issue. What we should do as next?
> >
> > Should I create a patch for this or do you want to make a patch?
>
> I'll take care of this, don't worry ;)
>
> Thanks for testing !
>
no problem. Maybe you can try to give me some explanation what you did
there?
I see you make a lockdep_set_class for each tx queue and assign the
lowpan_netdev_xmit_lock_key. So why it's better to make a own
"lock_key".
thanks.
- Alex
------------------------------------------------------------------------------
Android™ apps run on BlackBerry®10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience. Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
