Hello. On 03/05/2014 11:43 PM, Alexander Aring wrote:
> This patch adds a missing return after fragmentation init. Otherwise we > register a sysctl interface and deregister it afterwards which makes no > sense. > Signed-off-by: Alexander Aring <alex.ar...@gmail.com> > --- > net/ieee802154/reassembly.c | 2 ++ > 1 file changed, 2 insertions(+) > diff --git a/net/ieee802154/reassembly.c b/net/ieee802154/reassembly.c > index 4511fc2..59db7b5 100644 > --- a/net/ieee802154/reassembly.c > +++ b/net/ieee802154/reassembly.c > @@ -550,6 +550,8 @@ int __init lowpan_net_frag_init(void) > lowpan_frags.frag_expire = lowpan_frag_expire; > lowpan_frags.secret_interval = 10 * 60 * HZ; > inet_frags_init(&lowpan_frags); > + > + return 0; Perhaps 'goto out' for "consistency" with the code above? (I don't know why they used "goto out' in the first place.) > err_pernet: > lowpan_frags_sysctl_unregister(); > out: WBR, Sergei ------------------------------------------------------------------------------ Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce. With Perforce, you get hassle-free workflows. Merge that actually works. Faster operations. Version large binaries. Built-in WAN optimization and the freedom to use Git, Perforce or both. Make the move to Perforce. http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel