Hi Alex,
Sounds like a good plan, I'll review the new patch series once you've
finished.
Cheers,
Martin.
On 14/03/14 11:04, Alexander Aring wrote:
> On Fri, Mar 14, 2014 at 08:49:51AM +0000, Martin Townsend wrote:
>> Hi Alex,
>>
>> Do we need to free local_skb if we fail?
>>
>> if (fail) {
>> kfree_skb(local_skb);
>> goto drop;
>> }
>>
> Hi Martin, the correct error handling will be a big patch the reasons
> are:
>
> We have to convert all errno returns to return NET_RX_DROP. We should use
> NET_RX_DROP because we call in latest path on the 6LoWPAN adaptionlayer
> "return netif_rx(...)" which returns NET_RX_DROP or NET_RX_SUCCESS and
> this is not a errno. Means we can't check on error with "if (ret < 0)".
>
> Other thing is we cleanup too many times the skb also in the generic
> iphc code. The generic iphc code use NET_RX_DROP and -EINVAL also in some
> places... so we need to convert this to NET_RX_DROP also.
>
> At least bluetooth uses this code also and we need to rework the receive
> function of bluetooth 6LoWPAN...
>
> I already told you... it's a mess. :-)
>
> I will send tonight a patch series to fix this but I need some time for
> this and sorry for spamming.
>
> - Alex
--
Xsilon Ltd.
Tel +44 (0)1793 843109
www.xsilon.com
Bowman House, Whitehill Lane,
Royal Wooton Bassett,
Swindon. SN4 7DB.
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
