On Tue, 2014-03-18 at 20:32 -0700, Eric Dumazet wrote:
> On Tue, 2014-03-18 at 21:19 -0600, Jean Sacren wrote:
>
> > 2) Fix the initializer by deleting the double logical negation
> > operators as they don't serve any purpose.
> >
> ...
> >
> > static int phy_set_lbt(struct wpan_phy *phy, struct genl_info *info)
> > {
> > - u8 on = !!nla_get_u8(info->attrs[IEEE802154_ATTR_LBT_ENABLED]);
>
> You do realize !!(a) is not equivalent to (a) ?
It is when the type it's assigned to also changes
from u8 to bool.
I don't think it's a great style though.
I think the !! doesn't hurt here.
I'd've preferred it to be
bool on = nla_get_u8(...)
rather than separating the declaration from the assignment
by a few lines of code.
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
