On Thu, Mar 27, 2014 at 02:31:07PM +0530, Varka Bhadram wrote:
> Hai Alex,
> 
> > btw. I think the else would be here wrong because we can boot also
> > without devicetree if devicetree is enabled.I only see sometimes a
> > #ifdef CONFIG_OF in driver to give the compiler a little help to remove
> > the struct if it's not enabled.
> >
> 
> Ya you are right. But there is fundamental difference b/w DT and Non-DT in 
> linux
> kernel.
> 
> If the boards like Begleboneblack can have two types of linux kernel sources.
>          1. without board specific file (board info provided by device tree
> blob)
>           2. with board specific files
> I think any one of this can only possible. When you boot the kernel with DT
> support we cant find the
> board specific files.
> 
> > I think we should remove that #if IS_ENABLED(CONFIG_OF). The struct is
> > unused because of_match_ptr(at86rf230_of_match) returns NULL if
> > !CONFIG_OF
> 
> The only way visible to us is to include the #if #if IS_ENABLED(CONFIG_OF) for
> of_match_ptr(at86rf230_of_match) also.
> 
no, of_match_ptr will return NULL if CONFIG_OF is not defined. We don't
need any IS_ENABLED(CONFIG_OF).

see include/linux/of.h line 521

- Alex

------------------------------------------------------------------------------
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel

Reply via email to