Hi Varka,

please take the mailinglist always in CC. There are also other people
who knows more about the interrupt handling in at86rf230

On Fri, Mar 28, 2014 at 11:59:31AM +0530, Varka Bhadram wrote:
> Hai Alex,
> 
> I have small question about interrupt handling.
> 
> When an interrupt occur the control goes to the interrupt handler. In the
> interrupt handler interrupt on that irq line will be disabled automatically by
> the linux interrupt management, and re-enabled when the handler return with
> IRQ_HANDLED. We can check that by irqs_disabled() API.
> 
> But in the driver code you are explicitly disabling the interrupts by
> disable_irq_nosync(irq ) and re-enabling by enable_irq(). Is there any reason 
> ?
> 

The current driver is a mess, because the driver can sleep and isn't in
an atomic context. Phoebe talked about this issues several weeks ago, if
you have any improvements to this driver, please send patches with git
send-email to this list. Then we review it and you can send it to
netdev.

I really don't like to send it directly to netdev, of course you can do
that but if you don't already realized that. The complete stack and
6lowpan isn't maintained so david miller waits ~4 hours and apply it to
his branches and I don't have 4 hours to review and test it...
sometimes.

- Alex

------------------------------------------------------------------------------
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel

Reply via email to