Hi Stefan,

On Wed, Apr 23, 2014 at 11:37:20AM +0200, Stefan Schmidt wrote:
> Hello.
> 
> On Tue, 2014-04-22 at 20:55, Alexander Aring wrote:
> > This patch removes a unnecessary state read. The status value is never
> > evaluate after reading the state.
> > 
> > Signed-off-by: Alexander Aring <alex.ar...@gmail.com>
> > ---
> >  drivers/net/ieee802154/at86rf230.c | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/drivers/net/ieee802154/at86rf230.c 
> > b/drivers/net/ieee802154/at86rf230.c
> > index 5079036..6e6e742 100644
> > --- a/drivers/net/ieee802154/at86rf230.c
> > +++ b/drivers/net/ieee802154/at86rf230.c
> > @@ -967,10 +967,6 @@ static int at86rf230_hw_init(struct at86rf230_local 
> > *lp)
> >     u8 status;
> >     u8 csma_seed[2];
> >  
> > -   rc = at86rf230_read_subreg(lp, SR_TRX_STATUS, &status);
> > -   if (rc)
> > -           return rc;
> > -
> 
> I don't have the full code around right now but if status is never
> used you could also remove the variable all together or is it used
> again later?
> 

status is used for getting the dvdd value but I could rename status to
dvdd. I will do that and fixup it with this commit.

Thanks.

- Alex

------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel

Reply via email to