Hi Varka,
for me this patch looks good but wait for Alan's opinion. He knows much
more about the mrf24j40 driver.
There a are some whitespace issues in your code, please solve that.
On Wed, Apr 23, 2014 at 03:34:16PM +0530, Varka Bhadram wrote:
> This patch adds chekings and separate the mrf24j40 register initilalisation
> from mrf24j40_probe()
>
> Thanks and Regards
> Varka Bhadram.
>
> Signed-off-by: Varka Bhadram <var...@cdac.in>
> ---
> drivers/net/ieee802154/mrf24j40.c | 114
> ++++++++++++++++++++++++++++---------
> 1 file changed, 88 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/net/ieee802154/mrf24j40.c
> b/drivers/net/ieee802154/mrf24j40.c
> index 246befa..3f8449e 100644
> --- a/drivers/net/ieee802154/mrf24j40.c
> +++ b/drivers/net/ieee802154/mrf24j40.c
> @@ -609,10 +609,94 @@ out:
> return IRQ_HANDLED;
> }
>
> +static int mrf24j40_hw_init(struct mrf24j40 *devrec)
> +{
> + int ret;
> + u8 val;
> +
> + /* Initialize the device.
> + From datasheet section 3.2: Initialization. */
> + ret = write_short_reg(devrec, REG_SOFTRST, 0x07);
Here you use spaces instead tabs.
After you creating the patches with "format-patch" you need to check the
code style with checkpatch, this checks for things like this. Otherwise
some people at netdev ml will notice you about the issue.
You can find the checkpatch perl script inside linux source tree under
scripts. Simple run:
./scripts/checkpatch.pl --strict *.patch
after you creating the patches with format-patch.
- Alex
------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
