From: Varka Bhadram <varkabhad...@gmail.com>
Date: Wed,  9 Jul 2014 09:14:04 +0530

> diff --git a/net/ieee802154/6lowpan_iphc.c b/net/ieee802154/6lowpan_iphc.c
> index 511ddee..d85caa2 100644
> --- a/net/ieee802154/6lowpan_iphc.c
> +++ b/net/ieee802154/6lowpan_iphc.c
> @@ -49,12 +49,8 @@
>   * SUCH DAMAGE.
>   */
>  
> -#include <linux/bitops.h>
> -#include <linux/if_arp.h>
>  #include <linux/module.h>
> -#include <linux/netdevice.h>
>  #include <net/6lowpan.h>
> -#include <net/ipv6.h>
>  #include <net/af_ieee802154.h>
>  

These changes are completely bogus.

Where are the definitions of the data types for "struct in6_addr" and
"struct ipv6hdr" coming from.

I'm not even going to look at these patches until you:

1) Properly audit the files.  Removing an include and typing "make"
   is not auditing the header file requriements.  Reading the code
   and looking at where declarations and definitions actually come
   from _is_.

2) Write a real commit message, this one is way too terse and tells me
   nothing.  Explain why each header file was removed, and what the
   justification is.

------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel

Reply via email to