On Mon, Jul 14, 2014 at 01:55:45PM +0100, Martin Townsend wrote: > Hi Alex, > > Just to confirm that if a patch changes iphc.c then there should be separate > patch for 6lowpan_bt and another for 6lowpan_rtnl. >
I would do it so, it should not break any compiling. Then you can't use "git bisect" anymore -> code should be bisectable. Make only small change to fix this error, don't change the prototypes only if this is really necessary. it's easier to review: 1. Only generic code change and describe the new behaviour in the commit msg. 2. bluetooth changes according to the new behaviour. 3. 802.15.4 to the new behaviour. It should be easy to the reviewer that the 802.15.4/bluetooth use the new behaviour. If you need to change the API for the generic 6lowpan iphc code, then please make the necessary change in 802.15.4/bluetooth that the code compiles. - Alex ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck® Code Sight™ - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
