Hi Martin.
On Thu, Jul 24, 2014 at 09:31:13AM +0100, Martin Townsend wrote:
> This can potentially cause the console to be potentially overran with this
> message if you continually send frames that hit this path.
>
> Signed-off-by: Martin Townsend <martin.towns...@xsilon.com>
> ---
> net/6lowpan/iphc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/6lowpan/iphc.c b/net/6lowpan/iphc.c
> index 61b5206..4eca80f 100644
> --- a/net/6lowpan/iphc.c
> +++ b/net/6lowpan/iphc.c
> @@ -157,7 +157,7 @@ static int uncompress_context_based_src_addr(struct
> sk_buff *skb,
> /* TODO */
> case LOWPAN_IPHC_ADDR_03:
> /* TODO */
> - netdev_warn(skb->dev, "SAM value 0x%x not supported\n", sam);
> + pr_debug("SAM value 0x%x not supported\n", sam);
Yep, I introduce this about one year ago, sry.
You already note that we have mixed parts of logging functions which is
very bad. The better solution is to make a special 6lowpan logging
functionality.
This should look like the following [0] as a good example. This is from
the 80211 wireless implementation.
We need something like this in "include/net/6lowpan.h" and instead of
"wiphy" use "6lowpan" for the macro names. We can also call dev_info for
a netdevice, for ratelimited there also exist a dev_ratelimited_xxx
functions, see "include/linux/device.h". Then we need to change all
logging information according the new functions.
I don't have time right now to care about the logging functionality,
sorry.
- Alex
[0]
https://github.com/linux-wpan/linux-wpan-next/blob/master/include/net/cfg80211.h#L4830
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
