On Fri, Mar 2, 2012 at 07:11, Jonas Bonn <[email protected]> wrote:
>> It explodes somewhere in apply_relocate_add().
>> This function is anyway fishy:
>> case R_OR32_CONST:
>> location = (uint16_t *)location + 1;
>> *((uint16_t *)location) = (uint16_t) (value);
>> break;
>> case R_OR32_CONSTH:
>> location = (uint16_t *)location + 1;
>> *((uint16_t *)location) = (uint16_t) (value >> 16);
>> break;
>>
>> Why the cast to (uint16_t *)?
>
> This is for loading a 32 bit const, which is done in two steps:
>
> l.movhi rX,hi(const)
> l.ori rX,rX,lo(const)
>
> The immediate value 'const' here is encoded in the low 16 bits of those
> instructions.
So OpenRISC is big endian, which matches
arch/openrisc/include/asm/byteorder.h:#include <linux/byteorder/big_endian.h>
However, there are some remainings of little endian support:
arch/openrisc/include/asm/unaligned.h:#if defined(__LITTLE_ENDIAN)
arch/openrisc/include/asm/unaligned.h:#elif defined(__BIG_ENDIAN)
arch/openrisc/include/asm/unaligned.h:# error need to define endianess
> Since 'location' points at the 32-bit instruction in question, that cast
> is supposed to be saying: 'move 16 bit value into low 16 bits of
> instruction'.
It may be more readable and safer (w.r.t. changing endianness) to do
32-bit loads and stores and explicitly modify the 16 LSB.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
Linux mailing list
[email protected]
http://lists.openrisc.net/listinfo/linux
