Hi Tao,
Thanks. The patch looks good and I'll pull the change for 3.7.
A couple of things to note for future submissions:
i) Make sure your patch is based off of something in a public tree.
Your patch below has additional changes that are not in linux-next so
that the patch doesn't actually apply as is.
ii) In the future, please don't send patches as HTML mail. It's
preferable to use something like git-send-mail.
Thanks again,
Jonas
On 08/24/2012 09:25 AM, ApacheGT wrote:
or1k_pic_mask_ack() did not mask the irq.
Signed-off-by: Gong Tao <[email protected]
<mailto:[email protected]>>
---
arch/openrisc/kernel/irq.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/openrisc/kernel/irq.c b/arch/openrisc/kernel/irq.c
index a65aede..6619c91 100644
--- a/arch/openrisc/kernel/irq.c
+++ b/arch/openrisc/kernel/irq.c
@@ -91,9 +91,12 @@ static void or1k_pic_mask_ack(struct irq_data *data)
/* Comments for pic_ack apply here, too */
#ifdef CONFIG_OR1K_1200
+/* MUST mask first. added by [email protected]
<mailto:[email protected]> */
+mtspr(SPR_PICMR, mfspr(SPR_PICMR) & ~(1UL << data->hwirq));
mtspr(SPR_PICSR, mfspr(SPR_PICSR) & ~(1UL << data->hwirq));
#else
WARN(1, "Interrupt handling possibily broken\n");
+mtspr(SPR_PICMR, (1UL << data->hwirq));
mtspr(SPR_PICSR, (1UL << data->hwirq));
#endif
}
--
1.7.11.1
--
?? ??
Sincerely,
Gong Tao
? ???????,??????
School of Advanced Engineering @
Beihang UNIV.
Mail: gongtao0607[at]gmail[dot]com
<mailto:[email protected]>
Tel: +86 15210988463
--------------------
| OpenPGP keys: DE4CCC4F(gongtao0607[at]gmail[dot]com)
| OpenPGP fingerprint: 1C93 0B63 3466 74F2 D3C3 D873 4F7D 76E5 DE4C CC4F
--------------------
_______________________________________________
Linux mailing list
[email protected]
http://lists.openrisc.net/listinfo/linux
_______________________________________________
Linux mailing list
[email protected]
http://lists.openrisc.net/listinfo/linux
