Hi Jonas, Stefan,

On Wed, Nov 6, 2013 at 7:45 AM, Jonas Bonn <jo...@southpole.se> wrote:
> On 11/06/2013 12:21 AM, Stefan Kristiansson wrote:
>> Jonas, as a reminder, in addition to this and the __dev* patch for this
>> driver,

Sorry Stefan, I only noticed you sent these out a while ago afterwards.

>> there's also an issue with the data direction logic being reversed that's
>> addressed here:
>> http://lists.openrisc.net/pipermail/linux/2013-August/000439.html

I had noticed a reference to this in orpsoc commit
02a9f7fcbedada68c2c796b1b8b0267e314bea5c ("de0_nano: revert
workaround for jbtrivial gpio driver").

> I'll take your word for it that the data direction is inversed as per your
> patch, even though I'm a bit surprised because I thought we'd been using
> that driver in its current form elsewhere.

I can confirm the LEDs don't work without this patch, and they do (that's
what's hardware is for, driving LEDs, right? ;-) with the patch, when using
a DTS derived from Marek's at
https://github.com/mczerski/linux/commits/de0_nano/arch/openrisc/boot/dts/de0_nano.dts

BTW, any specific reason there's no DTS provided in arch/openrisc for
real hardware?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
_______________________________________________
Linux mailing list
Linux@lists.openrisc.net
http://lists.openrisc.net/listinfo/linux

Reply via email to